Skip to content

pkgsLLVM.llvmPackages_git.compiler-rt: replace stdlib.h with stddef.h…#297936

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

pkgsLLVM.llvmPackages_git.compiler-rt: replace stdlib.h with stddef.h…#297936
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Mar 22, 2024

fix build failure with pkgsLLVM.lvmPackages_git.compiler-rt on aarch64-linux

       > [276/406] Building C object lib/builtins/CMakeFiles/clang_rt.builtins-aarch64.dir/aarch64/sme-libc-routines.c.o
       > FAILED: lib/builtins/CMakeFiles/clang_rt.builtins-aarch64.dir/aarch64/sme-libc-routines.c.o
       > /nix/store/7ldihdrj6zf2jfqc6qb7zkwxhz16p1yw-aarch64-unknown-linux-gnu-clang-wrapper-18.1.0-rc4/bin/aarch64-unknown-linux-gnu-clang --target=aarch64-unknown-linux-gnu -DHAS_ASM_LSE -DVISIBILITY_HIDDEN  -nodefaultlibs -Wall -O3 -DNDEBUG -fno-lto -std=c11 -fPIC -fno-builtin -fvisibility=hidden -fomit-frame-pointer -DCOMPILER_RT_HAS_FLOAT16 -fno-builtin -MD -MT lib/builtins/CMakeFiles/clang_rt.builtins-aarch64.dir/aarch64/sme-libc-routines.c.o -MF lib/builtins/CMakeFiles/clang_rt.builtins-aarch64.dir/aarch64/sme-libc-routines.c.o.d -o lib/builtins/CMakeFiles/clang_rt.builtins-aarch64.dir/aarch64/sme-libc-routines.c.o -c /build/compiler-rt-src-18.1.0-rc4/compiler-rt/lib/builtins/aarch64/sme-libc-routines.c
       > clang: warning: argument unused during compilation: '-nostartfiles' [-Wunused-command-line-argument]
       > /build/compiler-rt-src-18.1.0-rc4/compiler-rt/lib/builtins/aarch64/sme-libc-routines.c:1:10: fatal error: 'stdlib.h' file not found
       >     1 | #include <stdlib.h>
       >       |          ^~~~~~~~~~
       > 1 error generated.

testing:
nix-build -A pkgsCross.aarch64-multiplatform.pkgsLLVM.llvmPackages_git.compiler-rt succeeds

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ghost ghost requested a review from RaitoBezarius as a code owner March 22, 2024 03:35
@ghost
Copy link
Author

ghost commented Mar 22, 2024

cc: @RossComputerGuy

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 22, 2024
@ghost
Copy link
Author

ghost commented Mar 25, 2024

superseded by #296284

@ghost ghost closed this Mar 25, 2024
@ghost ghost deleted the aarch64-compiler-rt-fix branch March 25, 2024 20:03
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

Assignees

No one assigned

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rrbutani